Metadata
- Source
- FLUID-1774
- Type
- Task
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Eli Cochran
- Reporter
- Anastasia Cheetham
- Created
2008-11-05T16:30:39.000-0500 - Updated
2009-06-03T13:45:30.000-0400 - Versions
-
- 0.6beta1
- Fixed Versions
-
- 0.6
- Component
-
- Inline Edit
Description
The InlineEdit afterFinish signature should change to:
afterFinished(newValue, editField, oldValue, viewElement)
dev-iteration46
Attachments
Comments
-
Eli Cochran commented
2008-11-05T18:21:42.000-0500 Added FLUID-1772-74.patch file which resolves FLUID-1772, FLUID-1773, FLUID-1774. Patch only changes InlineEdit.js. There are also changes to the Section Info InlineEdit sample code that go along with this, that have not yet been checked in.
All current InlineEdit jqUnit automated tests pass.
-
Antranig Basman commented
2008-11-06T14:21:02.000-0500 I have incorporated this patch as well as the one for FLUID-1772, although I have gone with the signature (newValue, oldValue, editField, viewElement) with the middle two arguments interchanged, for greater consistency with the current modelChanged - also the editField/viewElement arguments become more arguable with different varieties of InlineEdit, which might not have a single well-defined value-bearing node (e.g. if the editable view consisted of radio buttons, etc.) - we should discourage "sharing" these outside the component itself.
Also note that "afterFinished" itself has become "afterFinishEdit" in accordance with FLUID-1778.
Revision 5965