FLUID-1773: Change the signature of the modelChanged event

Metadata

Source
FLUID-1773
Type
Task
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Anastasia Cheetham
Created
2008-11-05T16:25:38.000-0500
Updated
2009-06-03T13:45:29.000-0400
Versions
  1. 0.6beta1
Fixed Versions
  1. 0.6
Component
  1. Inline Edit

Description

The Inline Edit modelChanged event signature should include 'that':
modelChanged(newValue, that)

dev-iteration46

Comments

  • Antranig Basman commented 2008-11-06T14:18:32.000-0500

    So far, I have adjusted modelChanged so that the signature is (newModel, oldModel, source). We need to review this, also in conjunction with FLUID-1771 - since the "source" field might be an annoyance for external users. Perhaps we could go with (newModel, oldModel, that, source)? Should we actually fix pipe-cutter events before doing this? Revision 5965

  • Eli Cochran commented 2008-11-07T11:49:38.000-0500

    My work is done here. However, Antranig has indicated that the signature may require additional tweaking.

  • Antranig Basman commented 2008-12-10T14:37:36.000-0500

    Signature is declared agreeable