FLUID-1606: Inline edit: Undo icon missing

Description

On http://build.fluidproject.org/fluid/sample-code/inline-edit/announcements/announcements.html, if you edit the Announcement title, the undo icon does not appear (as it should). See attached screenshot.

The undo icon should be right next to the item that was edited, as specified in the "Change Section name" scenario on this page: http://wiki.fluidproject.org/display/fluid/Simple+Text+Inline+Edit+Storyboard.

Attachments

Comments

• Justin Obara commented 2008-09-24T13:17:21.000-0400

  Bug Parade: 0.5 release

• Jacob Farber commented 2008-09-24T16:32:45.000-0400

  Undo is there now, but there is no icon just yet

• Anastasia Cheetham commented 2008-09-24T16:35:23.000-0400

  There seems to be a bug in the code (either InlineEdit or Undo, not sure which yet) resulting in the custom undo icon rendering not working (this explains why the icon in the bSpace example is not working, too). I'll investigate.

• Anastasia Cheetham commented 2008-09-24T16:43:56.000-0400

  I've committed a fix to the bug that caused the custom icon to not work. Jacob should be able to get it working now. r5670

• Jacob Farber commented 2008-09-24T16:47:35.000-0400

  Anastasia fixed custom undo renderer & icon was added to example

• Antranig Basman commented 2008-09-24T16:48:47.000-0400

  I've reviewed Anastasia's fix at 5670 and it is correct. Some stale code had been left behind at Fluid-js.

• Anastasia Cheetham commented 2008-09-24T16:54:44.000-0400

  The undo icon should be to the right of the text, not to the left.

• Jacob Farber commented 2008-09-24T16:58:47.000-0400

  Fixed placement of undo/redo, to the right of the editable text

• Anastasia Cheetham commented 2008-09-25T10:06:30.000-0400

  Jacob's fix looks good.

• Justin Obara commented 2008-09-25T10:26:10.000-0400

  Verified fix using:

  FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
  FF2, FF3, IE7, Opera 9.5 (Win XP)
  FF3, IE7 (Win Vista)