FLUID-1603: Make unit tests pass again :P

Metadata

Source
FLUID-1603
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Michelle D'Souza
Created
2008-09-22T16:06:59.000-0400
Updated
2008-09-25T14:44:41.000-0400
Versions
N/A
Fixed Versions
  1. 0.5
Component
  1. Image Reorderer
  2. Layout Reorderer
  3. Reorderer

Description

Comments

  • Justin Obara commented 2008-09-22T16:09:18.000-0400

    Bug Parade: 0.5 release

  • Antranig Basman commented 2008-09-24T03:41:35.000-0400

    Reorderer family tests functioning again as of revision 5659

  • Justin Obara commented 2008-09-24T08:56:31.000-0400

    There is an error when running the reorderer based unit tests in IE

  • Justin Obara commented 2008-09-24T09:35:32.000-0400

    some of the tests are failing again, unfortunately

  • Antranig Basman commented 2008-09-24T10:13:07.000-0400

    Recovered lightbox-based tests at revision 5662. 1 subcase of LayoutCustomiser test still fails under IE6.

  • Michelle D'Souza commented 2008-09-24T13:21:44.000-0400

    Commits up until revision 5664 have been reviewed by either myself or Antranig.

  • Justin Obara commented 2008-09-24T13:39:17.000-0400

    The following tests are still failing in IE

    Lightbox Tests:

    3 (28, 29, 34, 35)
    15 (76, 77, 82, 83)
    17 (124, 125, 130, 131)

    Layout Customizer Tests:

    2 (3, 5)

  • Antranig Basman commented 2008-09-24T16:37:41.000-0400

    I have spent some time investigating the IE Lightbox failures, which are all failures in the new test fixture I put in for FLUID-1589. There appears to be some really crazy condition whereby IE will "duplicate" a DOM node and therefore lead to the keyboard event target not being recognised. This condition will "go away" if an alert() is placed in the focus handler. It seems this test failure, despite being extremely disturbing, does not correspond to a real failure. Will continue to investigate.

  • Michelle D'Souza commented 2008-09-25T12:37:23.000-0400

    Tests all pass now in FF and IE. Commits have been reviewed.

  • Justin Obara commented 2008-09-25T14:44:41.000-0400

    Verified fix using:

    IE 7 (Win Vista)
    IE 6 (Win XP)