FLUID-1589: Keyboard navigation does not follow up/down wrap behaviour when the rows are not all equal in length

Metadata

Source
FLUID-1589
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Justin Obara
Created
2008-09-18T16:24:58.000-0400
Updated
2008-09-24T15:31:29.000-0400
Versions
  1. 0.5beta1
Fixed Versions
  1. 0.5
Component
  1. Image Reorderer
  2. Reorderer

Description

If the rows do not all contain an equal number of elements, when in a column with fewer elements the up/down wrapping will place you on the last element of the last row.

Steps to reproduce:

1) Open the lightbox demo from the daily build site:
http://build.fluidproject.org/fluid/sample-code/reorderer/generic-lightbox/generic-lightbox.html

2) Adjust the browser window size so that the images are laid out with the bottom row having fewer images than the other rows

3) Using the keyboard navigate to one of the shorter columns of images. Press the down arrow key. Notice that the at the end of the column, pressing down will place you on the last image of the last row instead of wrapping you around to the top.

Environments

FF2, FF3, Opera 9.5 (Mac OS 10.5)
FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
FF3, IE7 (Win Vista)
FF3, IE6 (Win 2000)

Attachments

Comments

  • Justin Obara commented 2008-09-18T16:26:27.000-0400

    'screenshot-1' shows an example of the layout. Pushing the down arrow when focus is on the Kiwano will place focus on the banana. Focus should be on the cherry

  • Justin Obara commented 2008-09-22T12:58:17.000-0400

    Bug Parade: 0.5 release

  • Antranig Basman commented 2008-09-24T12:14:52.000-0400

    Fixed at revision 5663

  • Anastasia Cheetham commented 2008-09-24T13:54:35.000-0400

    I've reviewed this commit (r5663) and it looks good, though I'd really like to see a different name for the option than "sentinelize" (a boolean) - how about "extendDropTarget" ?

  • Anastasia Cheetham commented 2008-09-24T13:57:14.000-0400

    Antranig - comments on the suggested option name change from "sentinelize" to "extendDropTarget" ?

  • Anastasia Cheetham commented 2008-09-24T15:15:49.000-0400

    Antranig and I discussed this, and agreed that the 'sentinelize' options should not be public, and therefore should not be documented, and therefore doesn't need a new name.

  • Justin Obara commented 2008-09-24T15:31:29.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.5 (Mac OS 10.5)
    FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
    FF3, IE7 (Win Vista)