FLUID-1335: Drop target based on position of pointer instead of avatar

Metadata

Source
FLUID-1335
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
Justin Obara
Created
2008-08-28T08:35:05.000-0400
Updated
2008-09-11T09:52:02.000-0400
Versions
  1. 0.5beta1
Fixed Versions
  1. 0.5
Component
  1. Image Reorderer
  2. Layout Reorderer
  3. Reorderer

Description

The drop target appears based on the location of the pointer instead of the location of the avatar. This means that since a user will likely pick up the avatar in different spots each time, the generation of the drop target may seem inconsistent.

Environments

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
FF3, IE7 (Win Vista)

Attachments

Comments

  • Justin Obara commented 2008-08-28T08:36:43.000-0400

    'screenshot-1' shows the location of the avatar to generate a drop target on the left side, when avatar is picked up from the left side.

  • Justin Obara commented 2008-08-28T08:44:27.000-0400

    'screenshot-2' shows the location of the avatar to generate a drop target on the left side, when avatar is picked up from the right side.

  • Simon Simon commented 2008-08-29T16:54:49.000-0400

    In Reorderer.js, initDropTarget(), droppable(), the tolerance is set to "pointer", which causes the "pointer" (mouse position) to activate the drop target.

    I tested set tolerance to be "intersect", and it looks better.

  • Justin Obara commented 2008-09-02T09:40:27.000-0400

    'screenshot-3' is the same as 'screenshot-1' but shows the location of the pointer

  • Justin Obara commented 2008-09-02T09:41:35.000-0400

    'screenshot-4' is the same as 'screenshot-2' but shows the location of the pointer

  • Antranig Basman commented 2008-09-07T18:58:12.000-0400

    We are no longer using JQuery UI droppable, and "intersect" whilst better was not perfect. We will need to handle the pointer-element offset ourselves for 0.5.

  • Paul Zablosky commented 2008-09-10T12:57:00.000-0400

    The behaviour can also be demonstrated with the "Sortable Vertical List" and "Sortable jQuery Tabs" examples on the daily build page.

  • Antranig Basman commented 2008-09-10T17:17:04.000-0400

    Fixed at revision 5510

  • Justin Obara commented 2008-09-11T09:52:02.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
    FF3, IE7 (Win Vista)