FLUID-1321: Undo returns to the original state, not the previous state

Metadata

Source
FLUID-1321
Type
Bug
Priority
Critical
Status
Closed
Resolution
Fixed
Assignee
Anastasia Cheetham
Reporter
Justin Obara
Created
2008-08-27T11:32:55.000-0400
Updated
2008-10-06T09:01:42.000-0400
Versions
  1. 0.4
  2. 0.5beta1
Fixed Versions
  1. 0.6beta1
Component
  1. Inline Edit

Description

Undo returns to the original state, not the previous state. If i make two changes the first change is ignored.

Steps to reproduce:

1) Open the bSpace demo from the daily build site:
http://build.fluidproject.org/fluid/sample-code/inline-edit/section-info/section-info.html

2) Edit one of the inline edit fields, make sure to save it so the undo icon appears.

3) Re-edit the same inline edit field.

4) Pressing the undo/redo button will toggle between the original state and the last edit. It should toggle between the last and second last edits.

dev-iteration43

Environments

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
FF3, IE7 (Win Vista)
FF3, IE6 (Win 2000)

Comments

  • Antranig Basman commented 2008-09-17T00:56:21.000-0400

    Resolved at revision 5550

  • Justin Obara commented 2008-09-17T09:11:19.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF2, FF3, Opera 9.5 (Win XP)
    FF3 (Win Vista)

  • Allison Bloodworth commented 2008-10-01T15:59:24.000-0400

    I am experiencing the same problem again. When I edit something twice, it toggles between the very last edit and the original state. It should only toggle between the very last edit and the edit just before that. I'm on Mac OS 10.5 with FF3.

  • Michelle D'Souza commented 2008-10-03T14:26:46.000-0400

    This seems to have come back as a result of the fix to FLUID-1594

  • Michelle D'Souza commented 2008-10-03T14:27:19.000-0400

    dev-iteration44

  • Anastasia Cheetham commented 2008-10-03T16:21:17.000-0400

    I think I've fixed this one without re-introducing FLUID-1594 again, i.e. both bugs should now be fixed. Hopefully, I haven't introduced or re-introduced anything else. Tests pass, and it all seems to work.

  • Justin Obara commented 2008-10-06T09:01:42.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
    FF3, IE7 (Win Vista)