FLOE-305: Improve the scrolling of the language panel to get rid of the tracking of the last moved height

Metadata

Source
FLOE-305
Type
Improvement
Priority
Major
Status
Closed
Resolution
Duplicate
Assignee
N/A
Reporter
Cindy Li
Created
2015-04-21T16:07:02.142-0400
Updated
2015-11-12T14:45:21.816-0500
Versions
N/A
Fixed Versions
N/A
Component
  1. First Discovery

Description

scrollLangIntoView() in the language panel keeps track of the last moved height in a private variable.

According to Antranig's comment (https://github.com/fluid-project/first-discovery/pull/31/files#r28700565), the use of this private variable is awkward and perhaps the biggest impediment to turning this into a generic fluid.scrollIntoView(controls, elements, index) function - is there perhaps some measurement that we can take from the DOM instead that will let us determine this? It seems that this will be fragile in the face of the user operating a scrolling control (if one appeared) in between invocations to this function.

Comments