ENGAGE-408: On an empty My Collection, grid/list toggle functionality should not exist

Description

Comments

• Jess Mitchell commented 2010-02-19T15:04:32.000-0500

  this is bad – it actually pops the user out to the browser and reloads the page with all kinds of weirdness

• Jess Mitchell commented 2010-02-19T15:05:36.000-0500

  Bug Parade Engage 0.3

• Colin Clark commented 2010-02-19T18:39:47.000-0500

  This is caused by an error in MyCollectionView.js:

  that.navBar.events.onToggle.addListener(function () {
  that.navigationList.toggleLayout();
  });

  We're assuming that the Navigation List subcomponent is always instantiated. If the user's collection is empty, this is not the case. We should change the code to guard against this case, like this:

  that.navBar.events.onToggle.addListener(function () {
  if (that.navigationList) {
  that.navigationList.toggleLayout();
  }
  });

• Colin Clark commented 2010-02-19T18:40:19.000-0500

  Justin is also working on a fix that completely removes the grid/list toggle when the collection is empty, since it is unnecessary.

• Colin Clark commented 2010-02-19T18:41:47.000-0500

  I committed the first half of this fix at r9458. Justin, can you review it for me?

• Justin Obara commented 2010-02-19T19:03:44.000-0500

  reviewed Colin's commit at r9458. It looks good. My changes have resulted in some refactoring that Colin should probably review.

• Justin Obara commented 2010-02-19T19:22:07.000-0500

  Added the second half of this fix that removes the toggle button if no artifacts have been collected.

  Assigning to colin for review.

• Colin Clark commented 2010-02-19T19:22:41.000-0500

  I reviewed Justin's changes and they look good. +1