Metadata
- Source
- ENGAGE-353
- Type
- Task
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Svetoslav Nedkov
- Reporter
- Colin Clark
- Created
2010-02-08T17:18:12.000-0500 - Updated
2010-02-12T14:09:03.000-0500 - Versions
-
- 0.3b
- Fixed Versions
-
- 0.3b
- Component
-
- Object Code Entry
Description
There is some test-related code in the Code Entry component (the simulateCheck() function, for example). This should be removed from the component in preparation for production and implemented as a unit test instead.
Attachments
Comments
-
Colin Clark commented
2010-02-08T17:18:30.000-0500 Bug Parade Engage 0.3
-
Svetoslav Nedkov commented
2010-02-11T09:02:43.000-0500 Attached ENGAGE-353.patch that removes the test code from the code entry component.
This patch makes obsolete the patch attached to:http://issues.fluidproject.org/browse/ENGAGE-293
named ENGAGE-293.native-couch-view.patch as it applies the changes that it contains.
-
Justin Obara commented
2010-02-11T20:21:22.000-0500 Committed the removal of test code from within the component, I had to do this manually as I had already started with and made changes to the out of data patch.
-
Colin Clark commented
2010-02-12T14:09:03.000-0500 I've reviewed Sveto's (and Justin's) fixes for this issue and they look good. There's probably more refactoring and improvement we can do to Object Code Entry to make it more testable in the long run, but it's great to see passing unit tests again! +1 for inclusion in Engage 0.3b