Metadata
- Source
- ENGAGE-351
- Type
- Sub-issue
- Priority
- Critical
- Status
- Closed
- Resolution
- Won't Fix
- Assignee
- y z
- Reporter
- Colin Clark
- Created
2010-02-08T17:07:14.000-0500 - Updated
2017-12-22T09:44:17.037-0500 - Versions
-
- 0.3b
- Fixed Versions
-
- 0.3
- Component
- N/A
Description
Attachments
Comments
-
y z commented
2010-02-19T18:49:56.000-0500 This patch is not fully functional yet, there's an older bug with the spinner background colour. So todo: fix the spinner background problem, put spinner everywhere.
-
Jess Mitchell commented
2010-02-22T15:22:55.000-0500 Bug Parade Engage 0.3
-
y z commented
2010-02-22T19:06:45.000-0500 This patch is almost working. There are 2 issues left:
1) make the home page working with spinner.
2) investigate why the spinner disappears on the ipod after a first second -
Colin Clark commented
2010-02-22T19:51:40.000-0500 Yura, I took a quick peek at your patch. Things look roughly as I expected. My only concern: it looks like a fair bit of markup has changed in many pages. Have you snuck a few other changes in here, or have tabs crept in perhaps? Or is there another reason why all of the navbar markup--as well as the body take in some cases--has changed on Artifact View, Browse, etc.?
Not a big deal, but definitely worth looking at before submitting a final patch
-
y z commented
2010-03-05T17:53:34.000-0500 spinner should go to shared/images in engage core
-
Antranig Basman commented
2010-03-10T00:58:04.000-0500 it seems a bit onerous to expect every implementor of a navigation link to apply a particular CSS class to it, and somewhat error-prone. Would it not be a better strategy to simply hook into the global fluid.engage.url.setLocation functions that we were obliged to provide for the condenser?
-
Colin Clark commented
2010-03-10T01:04:04.000-0500 Antranig's comments make sense to me, but it strikes me that we may want to extend the Screen Navigator to fire real events before and after a page change occurs, allowing us to add effects such as this spinner and cross-page animations.
-
Justin Obara commented
2017-12-22T09:44:17.036-0500 The repository has been archived.