ENGAGE-282: Catalogue Preview doesn't correctly handle cases where no artifacts are included in the catalogue

Metadata

Source
ENGAGE-282
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Colin Clark
Created
2010-01-23T13:33:16.000-0500
Updated
2010-02-04T15:56:17.000-0500
Versions
N/A
Fixed Versions
  1. 0.3b
Component
  1. Exhibitions

Description

At the moment, we don't handle the case where no artifacts have been included in the catalogue in a very graceful manner. The Catalogue Preview component, upon encountering an empty catalogue of artifacts, will just blast its container's parent. This is extremely brittle and the sort of thing that could cause hours of debugging if the parent component's (Exhibition View) markup ever changes.

Here's the suspect code:

if (that.model.length && that.model.length > 0) {
that.refreshView();
} else {
that.container.parent().remove();
}

We should remove this code entirely and ensure that Exhibition View doesn't render the catalogue section at all--or instantiate the preview component--unless there are actually artifacts in the exhibition.