ENGAGE-101: Invalid file paths in a Kettle app includes file causes a Rhino exception to be thrown, rather than a more meaningful exception

Metadata

Source
ENGAGE-101
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Colin Clark
Created
2009-09-26T22:38:13.000-0400
Updated
2009-11-10T11:57:27.000-0500
Versions
N/A
Fixed Versions
  1. 0.1
Component
  1. Kettle

Description

If a user specifies a file path in their includes file that doesn't point to a valid file, they don't get a meaningful error message. Instead, we fall into the finally block in RhinoLoader.loadFile(), where it tries to close the Rhino context.

This is a problem in the case of invalid paths, since (I think) the exception is thrown upon creation of the FileReader, before the Rhino context has even been entered.

We should probably just throw a friendly error in this case and avoid closing the Rhino context.

Comments

  • Antranig Basman commented 2009-10-02T12:55:16.000-0400

    Reordered finally block at 8215

  • Justin Obara commented 2009-11-10T11:57:27.000-0500

    Closed as per previous comment