DECA-258: Code that exposes invokers to listeners in the pre-init functions should be commented

Metadata

Source
DECA-258
Type
Task
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Justin Obara
Created
2012-05-16T08:37:10.042-0400
Updated
2012-05-18T14:47:45.011-0400
Versions
N/A
Fixed Versions
  1. 0.5
Component
  1. Export

Description

Several of the components use a strategy of pre-definining an invoker in the pre-init function so that they can be used in the listeners block. The code for this looks strange though, since it relies on the framework to re-write the function underneath. This should be properly commented in all situations.

see the chat in the irc channel around 08:39
http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2012-05-15

Comments

  • Justin Obara commented 2012-05-16T12:11:26.792-0400

    Added in the suggested comment and changed the calls to refershView to point at renderer.refreshView as per suggestions from the channel log.

    The changes can be found in my bitbucket repo:
    https://bitbucket.org/jobara/decapod-ui-05release

  • Justin Obara commented 2012-05-18T14:47:41.682-0400

    Merged into the project repo