Description
Currently the program block editor contains the functionality for the run button but it’s likely that we will move the run button elsewhere. We should factor the code so that this is an easy task to do.
Comments
-
Michelle D'Souza commented
2019-12-12T10:22:21.936-0500 Should we take this out of the 0.1 release?
-
Daniel Cho commented
2019-12-12T15:16:11.747-0500 Ah, there’s one thing I forgot – there’s one more styling needs to be done, which is inverting colours when the program is running.
To Simon:
I am thinking of using a property for ProgramBlockEditor from C2LC-84 to change class to apply colour changes like this:className={`ProgramBlockEditor__run-button ${this.props.activeProgramStepNum !== null ? ProgramBlockEditor__run-button--active : ''}`}I also filed an issue with bug type, which is C2LC-100 and I used the same property to disable the editor action buttons when the program is running.
-
Simon Bates commented
2019-12-13T13:57:53.584-0500 We will do this refactoring after 0.1
-
Daniel Cho commented
2019-12-20T14:53:05.355-0500 Probably it makes more sense to merge PR for C2LC-103 with this one and close the 103
-
Michelle D'Souza commented
2020-01-22T15:07:32.335-0500 Designs for 0.3 are quite different from 0.2. It’s likely that the Run Button code will be refactored but this specifically might not be done. We’ll open a more appropriate issue when we know