C2LC-576: CI builds should fail when flow type coverage is too low.

Metadata

Source
C2LC-576
Type
Bug
Priority
N/A
Status
Won't Fix
Resolution
N/A
Assignee
Simon Bates
Reporter
Tony Atkins [RtF]
Created
2022-01-05T09:54:08.922-0500
Updated
2024-06-03T11:00:37.542-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Coding Environment

Description

In C2LC-575, we upgraded CRA script to use version 5. The previous flow coverage checking we used in CI does not work with this version. This ticket covers writing a quick script to exit with a non-zero error code if src and/or test coverage levels are not met.

This would use as its input the JSON output from the following command.

npx flow batch-coverage --show-all src --json --pretty

At the end of the JSON output are summary statistics, which looking something like:

"statistics":{
    "files_in_directory":108,
    "covered_expressions":32154,
    "total_expressions":34892,
    "percentage":92.15
  }

Comments

  • Tony Atkins [RtF] commented 2022-01-11T04:07:00.997-0500

    This should be started when C2LC-575 is close enough to merging.

  • Simon Bates commented 2024-06-03T11:00:29.793-0400

    We will need to rework our usage of Flow when we upgrade to the "Types-First" model. Closing.