C2LC-558: Program steps and add nodes don't get focus when clicked in Safari.

Metadata

Source
C2LC-558
Type
Bug
Priority
N/A
Status
Done
Resolution
N/A
Assignee
N/A
Reporter
Tony Atkins [RtF]
Created
2021-12-06T09:42:38.255-0500
Updated
2022-07-12T15:36:58.717-0400
Versions
N/A
Fixed Versions
  1. Coding Env 1.5
Component
  1. Coding Environment

Description

If you activate the action menu for a step using the keyboard, the next tab takes you to the delete step icon.  If you activate the action menu for a step using the mouse, the next tab takes you to the next add step icon (if those are expanded).  This does not happen in Firefox or Chrome.

Comments

  • Tony Atkins [RtF] commented 2021-12-08T07:31:48.891-0500

    As we discussed in meetings and on the chat, this seems to be one symptom of a potentially larger problem.  It seems like the focus logic in ProgramBlockEditor.js doesn't work on Safari for either add nodes or command blocks.

  • Tony Atkins [RtF] commented 2021-12-08T08:01:45.956-0500

    This issue claims the behaviour is intentional.

    https://bugs.webkit.org/show_bug.cgi?id=13724

  • Tony Atkins [RtF] commented 2021-12-08T08:18:30.016-0500

    Apparently this is known behaviour for Safari:

    https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#clicking_and_focus

    Just to comment on why we don't see this with the command palette, in that case the focus styles are associated with the selected command variable, which we manage ourselves in response to clicks, et cetera.