C2LC-544: Replace all 'black' styles with the correct colour.

Metadata

Source
C2LC-544
Type
Bug
Priority
N/A
Status
Won't Fix
Resolution
N/A
Assignee
Simon Bates
Reporter
Tony Atkins [RtF]
Created
2021-11-16T05:11:59.884-0500
Updated
2024-04-23T11:23:37.966-0400
Versions
N/A
Fixed Versions
N/A
Component
  1. Coding Environment

Description

We use #1E1E1E as our "black", but various styles mistakenly use the literal word. This ticket covers creating a new variable and replacing all raw instances of 'black' (and #000000) with the variable.

Comments

  • Tony Atkins [RtF] commented 2021-11-16T05:35:23.854-0500

    @@Daniel Cho commented on a recent pull:

    I went through Figma, and we never use colour black for anywhere in the coding environment, so would be good to make a scss variable with name c2lc-black and update all usage of black to use the variable, but that should be in another ticket.

    Did you also mean that we should change the scene and page backgrounds? Here's a screenshot comparing #1e1e1e on the left and production on the right:

    I can see what you mean in figma, but it looks a little... faded?  If Sepi is happy with it, we can make the change.  If not, we can distinguish #1e1e1e from "actual black" somehow, perhaps with a second variable.