C2LC-309: Add minimal CSS linting.

Metadata

Source
C2LC-309
Type
Task
Priority
N/A
Status
To Do
Resolution
N/A
Assignee
N/A
Reporter
Created
2021-03-18T05:20:06.804-0400
Updated
2021-04-20T10:05:24.568-0400
Versions
N/A
Fixed Versions
N/A
Component
N/A

Description

`npx csslint src` run against develop-0.7 reveals a bunch of style issues we don't particular care about, but a few actual problems, notably trying to set the same property twice:

csslint: There are 9 problems in /Users/duhrer/Source/rtf/c2lc-coding-environment/src/ConfirmDeleteAllModal.css.

...

ConfirmDeleteAllModal.css
7: warning at line 31, col 5
Duplicate property 'grid-row-start' found.
    grid-row-start: 2;

ConfirmDeleteAllModal.css
8: warning at line 32, col 5
Duplicate property 'grid-row-end' found.
    grid-row-end: 3;

I can run this manually against my theming work for now and clean up the strays, but this seems like an easy thing to add.

We'd have to adjust some of the settings, for example, although I find it terribly useful to alphabetise properties, I don't know that we want to use that default. I'd be happy just to check for duplicates for now.

Comments

  • Tony Atkins [RtF] commented 2021-03-18T05:23:34.436-0400

    We may need to wait on this until this issue is resolved:

    https://github.com/CSSLint/parser-lib/issues/228

    Basically, the "fr" units used with grid templates are not supported.

  • Tony Atkins [RtF] commented 2021-03-18T05:33:19.379-0400

    Another alternative might be to use stylelint, which is used in the wider community.

  • Tony Atkins [RtF] commented 2021-03-18T05:45:27.791-0400

    One advantage of stylelint is that all rules are "opt in".